Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C58218FC6 for ; Fri, 4 Mar 2016 17:53:41 +0000 (UTC) Received: (qmail 9566 invoked by uid 500); 4 Mar 2016 17:53:41 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 9534 invoked by uid 500); 4 Mar 2016 17:53:41 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 9374 invoked by uid 99); 4 Mar 2016 17:53:41 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Mar 2016 17:53:41 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3E5F42C1F58 for ; Fri, 4 Mar 2016 17:53:41 +0000 (UTC) Date: Fri, 4 Mar 2016 17:53:41 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8976) platforms/android/build.gradle modifies android versionCode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180251#comment-15180251 ] ASF subversion and git services commented on CB-8976: ----------------------------------------------------- Commit 99d5ff7347dd7c886efc8c61537bb8ec5832b5b7 in cordova-android's branch refs/heads/master from [~bowserj] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=99d5ff7 ] CB-8976: Accidentally left in the crosswalk build from when I was experimenting with this file > platforms/android/build.gradle modifies android versionCode > ----------------------------------------------------------- > > Key: CB-8976 > URL: https://issues.apache.org/jira/browse/CB-8976 > Project: Apache Cordova > Issue Type: Bug > Components: Android > Environment: Android > Reporter: zack dykes > Assignee: Joe Bowser > > cordova 5.0.0 > platforms/android/build.gradle modifies android versionCode at ln 178 > as I understand it max size for versionCode is (2^31)-1 > http://stackoverflow.com/a/24246191/126600 > in my config.xml: > {code} > android-versionCode="1385039613" > {code} > when I run {{cordova build android}}, I get: > {code} > FAILURE: Build failed with an exception. > * Where: > Build file '/Users/zackd/dev/code/cordova/cordova-ansr-fat-client/ondeviceresearch/platforms/android/build.gradle' line: 178 > * What went wrong: > A problem occurred evaluating root project 'android'. > > For input string: "13850396130" > {code} > and build.gradle, ln 178 > {code} > versionCode cdvVersionCode ?: Integer.parseInt("" + privateHelpers.extractIntFromManifest("versionCode") + "0") > {code} > looks like this is appending "0" to my versionCode, producing 13850396130 which is larger than max size for android versionCode > if I mod ln 178 as follows, build succeeds > {code} > versionCode cdvVersionCode ?: Integer.parseInt("" + privateHelpers.extractIntFromManifest("versionCode")) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org