cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10963) cordova-android does not support multiple runtime permission requests
Date Fri, 25 Mar 2016 19:09:25 GMT

    [ https://issues.apache.org/jira/browse/CB-10963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212269#comment-15212269
] 

ASF GitHub Bot commented on CB-10963:
-------------------------------------

GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-android/pull/285

    CB-10963: Handle overlapping permission requests from plugins

    Adds support for overlapping permission requests from plugins (i.e. requests that are
made while another request is still pending). The old behavior was to just return the last
permission request, which meant that plugins could inadvertently cancel requests made by other
plugins.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-android CB-10963

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #285
    
----
commit 49112607c958fc5c623b10c3fa1b697b1f7f214e
Author: Richard Knoll <richard.b.knoll@gmail.com>
Date:   2016-03-25T18:07:27Z

    CB-10963: Handle overlapping permission requests from plugins

----


> cordova-android does not support multiple runtime permission requests
> ---------------------------------------------------------------------
>
>                 Key: CB-10963
>                 URL: https://issues.apache.org/jira/browse/CB-10963
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>         Environment: Marshmallow
>            Reporter: Richard B Knoll
>            Assignee: Richard B Knoll
>              Labels: android, reproduced, triaged
>
> If a plugin makes multiple permission requests before the user grants/denies them, only
the last one will get returned. More importantly, requests from multiple plugins can interfere
with each other.
> For example, if Plugin A makes a permission request and then Plugin B immediately makes
another permission request before the user grants/denies Plugin A's request, then Plugin A
will never receive the results of its request (Android seems to return permission requests
in reverse order of when they were made, so Plugin B will actually get the correct result
back).
> I've got a fix for this and will open a PR momentarily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message