cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10927) Framework references in plugin.xml file prevent Windows Universal projects from being used on other machines
Date Wed, 30 Mar 2016 15:19:25 GMT

    [ https://issues.apache.org/jira/browse/CB-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218120#comment-15218120
] 

ASF GitHub Bot commented on CB-10927:
-------------------------------------

Github user dubeejw commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/163#discussion_r57906698
  
    --- Diff: template/cordova/lib/PluginHandler.js ---
    @@ -85,12 +85,12 @@ var handlers = {
                 var src = obj.src;
                 var dest = src;
                 var type = obj.type;
    +            var targetDir = obj.targetDir || '';
     
                 if(type === 'projectReference') {
    -                project.addProjectReference(path.join(plugin.dir,src), getTargetConditions(obj));
    -            }
    -            else {
    -                var targetDir = obj.targetDir || '';
    +                dest = path.join('plugins', plugin.id, targetDir, src);
    +                project.addProjectReference(dest, getTargetConditions(obj));
    --- End diff --
    
    After looking more closely, there are two different calls being made here. One is to addProjectReference(),
and the other is to addReference().


> Framework references in plugin.xml file prevent Windows Universal projects from being
used on other machines
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-10927
>                 URL: https://issues.apache.org/jira/browse/CB-10927
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: James Dubee
>              Labels: triaged
>
> For Windows Universal, a framework reference in plugin.xml files results in a hardcoded
path being written to CordovaApp.sln, and CordovaApp.Phone.jsproj. This hardcoded path is
specific to the user's machine in which the plugin was installed on. This prevents moving
a project from one machine to another without manually editing CordovaApp.sln, and CordovaApp.Phone.jsproj.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message