cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10927) Framework references in plugin.xml file prevent Windows Universal projects from being used on other machines
Date Wed, 30 Mar 2016 15:08:25 GMT

    [ https://issues.apache.org/jira/browse/CB-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218105#comment-15218105
] 

ASF GitHub Bot commented on CB-10927:
-------------------------------------

Github user dubeejw commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/163#discussion_r57904729
  
    --- Diff: spec/unit/pluginHandler/windows.spec.js ---
    @@ -441,40 +451,47 @@ describe('windows project handler', function () {
                 });
             });
     
    -        describe('of <framework> elements', function () {
    +       describe('of <framework> elements', function () {
                 // This could be separated into individual specs, but that results in a lot
of copying and deleting the
                 // project files, which is not needed.
                 it('should remove from correct project files when conditions specified',
function () {
    +                var curDir;
    +                curDir = __dirname;
    +                process.chdir(path.join(curDir, '..', 'fixtures', 'testProj'));
    +
                     var frameworks = copyArray(valid_frameworks);
     
                     frameworks.forEach(function(framework) {
                         PluginHandler.getInstaller('framework')(framework, dummyPluginInfo,
dummyProject);
                     });
     
    -                var path = 'ItemGroup/Reference';
    --- End diff --
    
    A variable named differently from "path" has to be used here. This is because a variable
named "path" is already declared at the top of the file. See line 23: var path = require('path');.
In addition, path.join() is used in this code, so overwriting the "path" variable will cause
us to lose our reference to the path module.


> Framework references in plugin.xml file prevent Windows Universal projects from being
used on other machines
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-10927
>                 URL: https://issues.apache.org/jira/browse/CB-10927
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: James Dubee
>              Labels: triaged
>
> For Windows Universal, a framework reference in plugin.xml files results in a hardcoded
path being written to CordovaApp.sln, and CordovaApp.Phone.jsproj. This hardcoded path is
specific to the user's machine in which the plugin was installed on. This prevents moving
a project from one machine to another without manually editing CordovaApp.sln, and CordovaApp.Phone.jsproj.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message