cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10837) Add support for platform specific orientation
Date Tue, 15 Mar 2016 08:19:33 GMT

    [ https://issues.apache.org/jira/browse/CB-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194911#comment-15194911
] 

Vladimir Kotikov commented on CB-10837:
---------------------------------------

[~nikhilkh] It looks like the existing logic from [orientation parser|https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/parserhelper/preferences.js]
was ported incorrectly into Android platform during refactoring. It was fixed in lib and works
for Android@<5.0 ([4d5926a|https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=4d5926a])
but now needs to fixed in platform.

The question is that there is a lot of other valid orientations apart from {{nosensor}} and
some of them supported only in API>18. Should we still do any validation (we probably will
need to validate against current targetSDK as well) or just copy them to manifest as-is?

> Add support for platform specific orientation
> ---------------------------------------------
>
>                 Key: CB-10837
>                 URL: https://issues.apache.org/jira/browse/CB-10837
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Android
>    Affects Versions: 5.4.1
>            Reporter: dcz.switcher
>              Labels: build, mustfix
>
> Hi,
> I want to set Manifest.xml activity with android:screenOrientation="nosensor"
> http://developer.android.com/guide/topics/manifest/activity-element.html#screen
> In cordova doc : 
> Additionally, you can specify any platform-specific orientation value if you place the
<preference> element within a <platform> element:
> So, I do it in config.xml
> <platform name="android">
>         <preference name="orientation" value="nosensor" />
> </platform>
> but on build : 
> Unsupported global orientation: nosensor. Defaulting to value: default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message