cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10749) Use cordova-common.CordovaLogger in cordova-android
Date Fri, 04 Mar 2016 13:57:40 GMT

    [ https://issues.apache.org/jira/browse/CB-10749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179903#comment-15179903
] 

ASF GitHub Bot commented on CB-10749:
-------------------------------------

Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/268#discussion_r55032070
  
    --- Diff: bin/templates/cordova/loggingHelper.js ---
    @@ -0,0 +1,18 @@
    +var CordovaLogger = require('cordova-common').CordovaLogger;
    +
    +module.exports = {
    +    adjustLoggerLevel: function (opts) {
    +        if (opts instanceof Array) {
    +            opts.silent = opts.indexOf('--silent') !== -1;
    +            opts.verbose = opts.indexOf('--verbose') !== -1;
    --- End diff --
    
    Added, thanks!


> Use cordova-common.CordovaLogger in cordova-android
> ---------------------------------------------------
>
>                 Key: CB-10749
>                 URL: https://issues.apache.org/jira/browse/CB-10749
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>
> We need to replace custom logging in CLI and platforms with now default implementation
from CB-10176. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message