cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10723) iOS9.2 no audio
Date Wed, 09 Mar 2016 20:11:40 GMT

    [ https://issues.apache.org/jira/browse/CB-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187832#comment-15187832
] 

ASF GitHub Bot commented on CB-10723:
-------------------------------------

Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/85#discussion_r55581042
  
    --- Diff: src/ios/CDVSound.m ---
    @@ -216,14 +216,14 @@ - (void)create:(CDVInvokedUrlCommand*)command
         NSString* mediaId = [command argumentAtIndex:0];
         NSString* resourcePath = [command argumentAtIndex:1];
     
    -    CDVAudioFile* audioFile = [self audioFileForResource:resourcePath withId:mediaId
doValidation:NO forRecording:NO];
    +    CDVAudioFile* audioFile = [self audioFileForResource:resourcePath withId:mediaId
doValidation:YES forRecording:NO];
    --- End diff --
    
    Sorry, my bad. was reviewing the wrong commit


> iOS9.2 no audio
> ---------------
>
>                 Key: CB-10723
>                 URL: https://issues.apache.org/jira/browse/CB-10723
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Media
>    Affects Versions: 2.2.0
>         Environment: IonicFramework | ngCordova | cordova-plugin-media
>            Reporter: Johnny Dong
>            Assignee: Omar Mefire
>              Labels: easyfix, iOS, pendingPR, triaged
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Found an issue with the latest cordova.plugin.media whilst i was putting together a IonicFramework
app for iOS 9.2.1 (iPhone 6s) to play an M4A file.
> The iOS logs would show:
> - Found resource '[path].m4a' in the web folder.
> Playing audio sample '[path].m4a'
> - Playing stream with AVPlayer & custom rate
> but no sound (both simulator + device)
> Debugging in Xcode, ./cordova-plugin-media/src/ios/CDVSound.m,ln 352 + 355 appears to
be the culprit.
> Instead of using "avPlayer" which doesn't appear to have a handle to the sound resource,
switching to "audioFile.player" appears to resolve the sound issue.
> *** ./cordova-plugin-media/src/ios/CDVSound.m,ln 352
> from:
> [avPlayer setRate:customRate];
> to:
> [audioFile.player setRate:customRate];
> *** ./cordova-plugin-media/src/ios/CDVSound.m,ln 355
> from:
> [avPlayer play];
> to:
> [audioFile.player play];
> NOTE: I've yet to create a PR as I have not signed the Apache ICLA, however i've committed
a code in my personal fork and happy for somebody to have a look at it and submit on my behalf:
> https://github.com/spudmashmedia/cordova-plugin-media/commit/946ffcf569cbaa22241e8ec00f11b4a52a0c6809



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message