cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10688) Cordova Plugin Splashscreen Readme must have examples
Date Fri, 04 Mar 2016 05:49:40 GMT

    [ https://issues.apache.org/jira/browse/CB-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179376#comment-15179376
] 

ASF GitHub Bot commented on CB-10688:
-------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r54992597
  
    --- Diff: README.md ---
    @@ -166,9 +217,10 @@ screen is meant to be visible before your app has started, that would
seem to
     defeat the purpose of the splash screen.  Providing some configuration in
     `config.xml` will automatically `show` the splash screen immediately after your
     app launch and before it has fully started and received the `deviceready`
    -event. See [Icons and Splash Screens](http://cordova.apache.org/docs/en/edge/config_ref_images.md.html)
    +event. See [Icons and Splash Screens][Icons and Splash Screens]
    --- End diff --
    
    Your change adds the docs here - so you need not even reference this page - correct?


> Cordova Plugin Splashscreen Readme must have examples
> -----------------------------------------------------
>
>                 Key: CB-10688
>                 URL: https://issues.apache.org/jira/browse/CB-10688
>             Project: Apache Cordova
>          Issue Type: Task
>            Reporter: Sarangan Rajamanickam
>            Assignee: Sarangan Rajamanickam
>              Labels: Docs-6.x
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message