cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10178) Unclear windows phone documentation for icons and splash screens
Date Tue, 15 Mar 2016 20:23:33 GMT

    [ https://issues.apache.org/jira/browse/CB-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196165#comment-15196165
] 

ASF GitHub Bot commented on CB-10178:
-------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/558#discussion_r56233993
  
    --- Diff: www/docs/en/6.x/config_ref/images.md ---
    @@ -119,6 +120,39 @@ different screen resolutions.
     - [App icon and image size guidelines](https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html)
     
     ##Windows
    +
    +For Windows the recommended approach to define app icons is to use `target` attribute.
    +
    +```xml
    +    <platform name="windows">
    +        <icon src="res/windows/storelogo.png" target="StoreLogo" />
    +        <icon src="res/windows/smalllogo.png" target="Square30x30Logo" />
    +        <icon src="res/Windows/Square44x44Logo.png" target="Square44x44Logo" />
    --- End diff --
    
    Perhaps we should clarify that.


> Unclear windows phone documentation for icons and splash screens
> ----------------------------------------------------------------
>
>                 Key: CB-10178
>                 URL: https://issues.apache.org/jira/browse/CB-10178
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Docs
>    Affects Versions: 5.4.0
>         Environment: Phonegap CLI, building to Windows platform. Testing on physical
windows phone device and on windows phone emulator. 
>            Reporter: Rupert McKay
>            Assignee: Nikhil Khandelwal
>            Priority: Minor
>              Labels: Docs-6.x, triaged, windows
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/images.md
> In the section 'Configuring Icons in the CLI' the windows sections neglect to mention
the affect adding a .scale-100 or .scale-240 extension can have to how source images get mapped
to destination images. 
> The examples provided will all default to mapping onto .scale-100. 
> Recommend adding examples like the following:
> {code:xml}
>     <platform name="windows">
>         <icon src="www/res/windows/SplashScreenPhone.scale-240.png" width="1152" height="1920"
/>
>         <icon src="www/res/windows/Square30x30Logo.scale-100.png" width="30" height="30"
/>
>         <icon src="www/res/windows/Square44x44Logo.scale-100.png" width="44" height="44"
/>
>         <icon src="www/res/windows/Square44x44Logo.scale-240.png" width="106" height="106"
/>
>         <icon src="www/res/windows/Square70x70Logo.scale-100.png" width="70" height="70"
/>
>         <icon src="www/res/windows/Square71x71Logo.scale-100.png" width="71" height="71"
/>
>         <icon src="www/res/windows/Square71x71Logo.scale-240.png" width="170" height="170"
/>
>         <icon src="www/res/windows/Square150x150Logo.scale-100.png" width="150" height="150"
/>
>         <icon src="www/res/windows/Square150x150Logo.scale-240.png" width="360" height="360"
/>
>         <icon src="www/res/windows/Square310x310Logo.scale-100.png" width="310" height="310"
/>
>         <icon src="www/res/windows/StoreLogo.scale-100.png" width="50" height="50"
/>
>         <icon src="www/res/windows/StoreLogo.scale-240.png" width="120" height="120"
/>
>         <icon src="www/res/windows/Wide310x150Logo.scale-240.png" width="744" height="360"
/>
>         <icon src="www/res/windows/Wide310x150Logo.scale-100.png" width="310" height="150"
/>
>         <splash src="www/res/windows/SplashScreen.scale-100.png" width="620" height="300"
/>
>     </platform>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message