cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10178) Unclear windows phone documentation for icons and splash screens
Date Wed, 02 Mar 2016 23:24:18 GMT

    [ https://issues.apache.org/jira/browse/CB-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176698#comment-15176698
] 

ASF GitHub Bot commented on CB-10178:
-------------------------------------

Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/528#discussion_r54810855
  
    --- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md ---
    @@ -93,30 +95,28 @@ the platform-specific `config.xml` file to make the platform aware
of
     the additional code library.  The `header-file` and `source-file` tags
     specify the path to the library's component files.
     
    -## Validating a Plugin
    +## Validating a Plugin using Plugman
     
     You can use the `plugman` utility to check whether the plugin installs
     correctly for each platform.  Install `plugman` with the following
     [node](http://nodejs.org/) command:
     
    -        $ npm install -g plugman
    +```bash
    +    $ npm install -g plugman
    +```
     
     You need an valid app source directory, such as the top-level `www`
     directory included in a default CLI-generated project as described in
    -[The Command-Line Interface](../../cli/index.html).  Make sure the app's `index.html`
home
    -page reference the name of the plugin's JavaScript interface, as if it
    -were in the same source directory:
    -
    -        <script src="myplugin.js"></script>
    +[Create your first app guide](../../cli/index.html).  
    --- End diff --
    
    Remove 'guide' as part of the link.


> Unclear windows phone documentation for icons and splash screens
> ----------------------------------------------------------------
>
>                 Key: CB-10178
>                 URL: https://issues.apache.org/jira/browse/CB-10178
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Docs
>    Affects Versions: 5.4.0
>         Environment: Phonegap CLI, building to Windows platform. Testing on physical
windows phone device and on windows phone emulator. 
>            Reporter: Rupert McKay
>            Assignee: Nikhil Khandelwal
>            Priority: Minor
>              Labels: Docs-6.x, triaged, windows
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/images.md
> In the section 'Configuring Icons in the CLI' the windows sections neglect to mention
the affect adding a .scale-100 or .scale-240 extension can have to how source images get mapped
to destination images. 
> The examples provided will all default to mapping onto .scale-100. 
> Recommend adding examples like the following:
> {code:xml}
>     <platform name="windows">
>         <icon src="www/res/windows/SplashScreenPhone.scale-240.png" width="1152" height="1920"
/>
>         <icon src="www/res/windows/Square30x30Logo.scale-100.png" width="30" height="30"
/>
>         <icon src="www/res/windows/Square44x44Logo.scale-100.png" width="44" height="44"
/>
>         <icon src="www/res/windows/Square44x44Logo.scale-240.png" width="106" height="106"
/>
>         <icon src="www/res/windows/Square70x70Logo.scale-100.png" width="70" height="70"
/>
>         <icon src="www/res/windows/Square71x71Logo.scale-100.png" width="71" height="71"
/>
>         <icon src="www/res/windows/Square71x71Logo.scale-240.png" width="170" height="170"
/>
>         <icon src="www/res/windows/Square150x150Logo.scale-100.png" width="150" height="150"
/>
>         <icon src="www/res/windows/Square150x150Logo.scale-240.png" width="360" height="360"
/>
>         <icon src="www/res/windows/Square310x310Logo.scale-100.png" width="310" height="310"
/>
>         <icon src="www/res/windows/StoreLogo.scale-100.png" width="50" height="50"
/>
>         <icon src="www/res/windows/StoreLogo.scale-240.png" width="120" height="120"
/>
>         <icon src="www/res/windows/Wide310x150Logo.scale-240.png" width="744" height="360"
/>
>         <icon src="www/res/windows/Wide310x150Logo.scale-100.png" width="310" height="150"
/>
>         <splash src="www/res/windows/SplashScreen.scale-100.png" width="620" height="300"
/>
>     </platform>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message