cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8976) platforms/android/build.gradle modifies android versionCode
Date Sat, 05 Mar 2016 00:24:41 GMT

    [ https://issues.apache.org/jira/browse/CB-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181340#comment-15181340
] 

ASF GitHub Bot commented on CB-8976:
------------------------------------

GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-docs/pull/540

    CB-8976: Restoring documentation for android version code

    The version code documentation was lost in the update to the config.xml reference. This
restores that old information and moves it to the Android guide. I also tried to clarify how
we modify the version code because there was some confusion over that in the [CB-8976](https://issues.apache.org/jira/browse/CB-8976)
thread.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-docs CB-8976

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #540
    
----
commit 4cccbc700fecf6f0a9f2a796df9f136a72d05fb2
Author: riknoll <richard.b.knoll@gmail.com>
Date:   2016-03-05T00:10:59Z

    CB-8976: Restoring documentation for android version code

----


> platforms/android/build.gradle modifies android versionCode
> -----------------------------------------------------------
>
>                 Key: CB-8976
>                 URL: https://issues.apache.org/jira/browse/CB-8976
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>         Environment: Android
>            Reporter: zack dykes
>            Assignee: Joe Bowser
>            Priority: Minor
>
> cordova 5.0.0
> platforms/android/build.gradle modifies android versionCode at ln 178
> as I understand it max size for versionCode is (2^31)-1 
> http://stackoverflow.com/a/24246191/126600
> in my config.xml: 
> {code}
> android-versionCode="1385039613"
> {code}
> when I run {{cordova build android}}, I get:
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file '/Users/zackd/dev/code/cordova/cordova-ansr-fat-client/ondeviceresearch/platforms/android/build.gradle'
line: 178
> * What went wrong:
> A problem occurred evaluating root project 'android'.
> > For input string: "13850396130"
> {code}
> and build.gradle, ln 178
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" + privateHelpers.extractIntFromManifest("versionCode")
+ "0")
> {code}
> looks like this is appending "0" to my versionCode, producing 13850396130 which is larger
than max size for android versionCode
> if I mod ln 178 as follows, build succeeds
> {code}
> versionCode cdvVersionCode ?: Integer.parseInt("" + privateHelpers.extractIntFromManifest("versionCode"))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message