Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D7FC018861 for ; Mon, 22 Feb 2016 21:02:27 +0000 (UTC) Received: (qmail 90751 invoked by uid 500); 22 Feb 2016 21:02:18 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 90727 invoked by uid 500); 22 Feb 2016 21:02:18 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 90664 invoked by uid 99); 22 Feb 2016 21:02:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Feb 2016 21:02:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 284702C1F57 for ; Mon, 22 Feb 2016 21:02:18 +0000 (UTC) Date: Mon, 22 Feb 2016 21:02:18 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-10668) move node_modules to package.json and update create script to copy from root MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-10668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157689#comment-15157689 ] ASF GitHub Bot commented on CB-10668: ------------------------------------- Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/33#issuecomment-187380673 +1 LGTM > move node_modules to package.json and update create script to copy from root > ---------------------------------------------------------------------------- > > Key: CB-10668 > URL: https://issues.apache.org/jira/browse/CB-10668 > Project: Apache Cordova > Issue Type: Improvement > Components: iOS, OSX > Reporter: Steve Gill > Assignee: Steve Gill > > Right now, node_modules lives in cordova-ios/bin/node_modules. That means we aren't managing those deps anywhere (not in package.json). I propose moving these into the root package.json and adding them as bundledDependenceis. Then update the create script to copy the root/node_modules directory instead of root/bin/node_modules. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org