Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D25918A8A for ; Wed, 24 Feb 2016 09:09:28 +0000 (UTC) Received: (qmail 36765 invoked by uid 500); 24 Feb 2016 09:09:18 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 36739 invoked by uid 500); 24 Feb 2016 09:09:18 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 36706 invoked by uid 99); 24 Feb 2016 09:09:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Feb 2016 09:09:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3147F2C1F57 for ; Wed, 24 Feb 2016 09:09:18 +0000 (UTC) Date: Wed, 24 Feb 2016 09:09:18 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-10636) Add JSHint for plugins MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162697#comment-15162697 ] ASF GitHub Bot commented on CB-10636: ------------------------------------- Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53910671 --- Diff: src/firefoxos/FileProxy.js --- @@ -67,10 +69,12 @@ QUIRKS: exports.requestFileSystem = function(successCallback, errorCallback, args) { var type = args[0]; - var size = args[1]; + //var size = args[1]; --- End diff -- Please either remove commented lines, or add an additional message why this commented out but not removed > Add JSHint for plugins > ---------------------- > > Key: CB-10636 > URL: https://issues.apache.org/jira/browse/CB-10636 > Project: Apache Cordova > Issue Type: Task > Reporter: Sergey Shakhnazarov > Assignee: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org