Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 12 Feb 2016 20:28:18 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12936362.1454512371000.40815.1455308898467@Atlassian.JIRA>
In-Reply-To: <JIRA.12936362.1454512371000@Atlassian.JIRA>
References: <JIRA.12936362.1454512371000@Atlassian.JIRA>
 <JIRA.12936362.1454512371929@arcas>
Subject: [jira] [Commented] (CB-10518) Cordova reports error events with
 incorrect log level
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145236#comment-15145236 ] 

ASF GitHub Bot commented on CB-10518:
-------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/383#discussion_r52794281
  
    --- Diff: cordova-lib/src/cordova/run.js ---
    @@ -44,7 +44,7 @@ module.exports = function run(options) {
         }).then(function() {
             return hooksRunner.fire('after_run', options);
         }, function(error) {
    -        events.emit('log', 'ERROR running one or more of the platforms: ' + error + '\nYou may not have the required environment or OS to run this project');
    +        events.emit('warn', 'ERROR running one or more of the platforms: ' + error + '\nYou may not have the required environment or OS to run this project');
    --- End diff --
    
    As in the first comment I'm not sure if we should emit this here because it is not consistent and not very informative. Maybe rethrow with this message. @nikhilkh, what do you think?


> Cordova reports error events with incorrect log level
> -----------------------------------------------------
>
>                 Key: CB-10518
>                 URL: https://issues.apache.org/jira/browse/CB-10518
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 6.0.0
>            Reporter: Vladimir Kotikov
>            Priority: Minor
>              Labels: triaged
>
> In case of fatal errors {{cordova run}} and {{cordova emulate}} methods emit error messages using {{log}} event. This code probably should be changed to use 'warn' level. (We can't use 'error' here due to its special meaning in Node: https://nodejs.org/api/events.html#events_error_events)
> There is also other places, where 'log' events is used incorrectly:
> cordova-lib\src\cordova\targets.js:        events.emit('log', 'An unexpected error has occured');
> cordova-lib\src\plugman\browserify.js:        events.emit('log', 'error while generating cordova.js');
> cordova-lib\src\plugman\browserify.js:            events.emit('log', 'Error running platform version script');


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org