cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10668) move node_modules to package.json and update create script to copy from root
Date Mon, 22 Feb 2016 21:02:18 GMT

    [ https://issues.apache.org/jira/browse/CB-10668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157689#comment-15157689
] 

ASF GitHub Bot commented on CB-10668:
-------------------------------------

Github user tripodsan commented on the pull request:

    https://github.com/apache/cordova-osx/pull/33#issuecomment-187380673
  
    +1 LGTM


> move node_modules to package.json and update create script to copy from root
> ----------------------------------------------------------------------------
>
>                 Key: CB-10668
>                 URL: https://issues.apache.org/jira/browse/CB-10668
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS, OSX
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>
> Right now, node_modules lives in cordova-ios/bin/node_modules. That means we aren't managing
those deps anywhere (not in package.json). I propose moving these into the root package.json
and adding them as bundledDependenceis. Then update the create script to copy the root/node_modules
directory instead of root/bin/node_modules.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message