cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-10662) Adding browser platform fails if plugins added since fix for CB-10641
Date Thu, 25 Feb 2016 01:20:18 GMT


ASF GitHub Bot commented on CB-10662:

Github user TimBarham commented on the pull request:
    A simpler fix might be: since all we're looking for is the project's `id`, why not fall
back on the main Cordova project's `config.xml` if we don't find a platform specific one?
We could change this in `cordova-lib\src\plugman\platforms\browser.js`. Or, since this code
is fairly common across several platforms, we could provide a single implementation (in `common.js`,
perhaps?) for those that need it.

> Adding browser platform fails if plugins added since fix for CB-10641
> ---------------------------------------------------------------------
>                 Key: CB-10662
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Tim Barham
>            Assignee: Vladimir Kotikov
>            Priority: Blocker
>              Labels: browser, regression, triaged
> Since the fix for [CB-10641|], adding the
browser platform throws an exception if a plugin has been added to the project:
> {noformat}
> $ cordova create AddBrowserError
> Creating a new cordova project.
> $ cd AddBrowserError
> $ cordova plugin add cordova-plugin-device
> Fetching plugin "cordova-plugin-device@~1.1.1" via npm
> $ cordova platform add browser
> Adding browser project...
> Running command: cmd "/s /c "cordova-browser\4.0.0\package\bin\create.bat AddBrowserError\platforms\browser
io.cordova.hellocordova HelloCordova""
> Creating Browser project. Path: platforms\browser
> Installing "cordova-plugin-device" for browser
> Failed to install 'cordova-plugin-device':Error: ENOENT: no such file or directory, open
>     at Error (native)
>     at Object.fs.openSync (fs.js:549:18)
>     at Object.fs.readFileSync (fs.js:397:15)
>     at Object.module.exports.parseElementtreeSync (cordova-common\src\util\xml-helpers.js:118:27)
>     at Object.module.exports.package_name (cordova-lib\src\plugman\platforms\browser.js:51:38)
>     at cordova-lib\src\platforms\PlatformApiPoly.js:264:67
>     at _fulfilled (cordova-common\node_modules\q\q.js:834:54)
>     at self.promiseDispatch.done (cordova-common\node_modules\q\q.js:863:30)
>     at Promise.promise.promiseDispatch (cordova-common\node_modules\q\q.js:796:13)
>     at cordova-common\node_modules\q\q.js:857:14
> {noformat}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message