cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Homer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-10654) _platform_add hooks not executed when platform added from repo or directory
Date Sat, 20 Feb 2016 04:52:18 GMT

     [ https://issues.apache.org/jira/browse/CB-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tony Homer updated CB-10654:
----------------------------
    Description: 
platform-specific before_platform_add and after_platform_add hooks are not executed when platforms
are added from directory or repo.  
e.g., hooks defined in config.xml as follows
{code}
<platform name="android">
<hook type="before_platform_add" src="scripts/before_platform_add/android/001_test.js"
/>
<hook type="after_platform_add" src="scripts/after_platform_add/android/001_test.js" />
</platform>
{code}

This is because the matching logic in platform.js depends on the targets specified in command
line arguments.
It seems that the matching logic should be deferred until the platform can be determined via
getPlatformDetailsFromDir.
This would require that the before_platform_add hook not be executed until after the platform
has been downloaded.

Steps to reproduce
# create a project with platform-specific hooks for before_platform_add and/or after_platform_add
defined in config.xml
# add platform from npm, e.g.
{code}
cordova platform add android
{code}
# hooks get executed
# add platform from repo or local dir, e.g.
{code}
cordova platform add https://github.com/apache/cordova-android
cordova platform add my-local-copy-of-cordova-android
{code}
# hooks do not get executed

  was:
before_platform_add and after_platform_add hooks are not executed when platforms are added
from directory or repo.  This is because the matching logic in platform.js depends on the
targets specified in command line arguments.
It seems that the matching logic should be deferred until the platform can be determined via
getPlatformDetailsFromDir.
This would require that the before_platform_add hook not be executed until after the platform
has been downloaded.

Steps to reproduce
# create a project with hooks for before_platform_add and/or after_platform_add
# add platform from repo or local dir, e.g.
{code}
cordova platform add https://github.com/apache/cordova-android
cordova platform add my-local-copy-of-cordova-android
{code}
# hooks do not get executed


> _platform_add hooks not executed when platform added from repo or directory
> ---------------------------------------------------------------------------
>
>                 Key: CB-10654
>                 URL: https://issues.apache.org/jira/browse/CB-10654
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Tony Homer
>            Assignee: Tony Homer
>
> platform-specific before_platform_add and after_platform_add hooks are not executed when
platforms are added from directory or repo.  
> e.g., hooks defined in config.xml as follows
> {code}
> <platform name="android">
> <hook type="before_platform_add" src="scripts/before_platform_add/android/001_test.js"
/>
> <hook type="after_platform_add" src="scripts/after_platform_add/android/001_test.js"
/>
> </platform>
> {code}
> This is because the matching logic in platform.js depends on the targets specified in
command line arguments.
> It seems that the matching logic should be deferred until the platform can be determined
via getPlatformDetailsFromDir.
> This would require that the before_platform_add hook not be executed until after the
platform has been downloaded.
> Steps to reproduce
> # create a project with platform-specific hooks for before_platform_add and/or after_platform_add
defined in config.xml
> # add platform from npm, e.g.
> {code}
> cordova platform add android
> {code}
> # hooks get executed
> # add platform from repo or local dir, e.g.
> {code}
> cordova platform add https://github.com/apache/cordova-android
> cordova platform add my-local-copy-of-cordova-android
> {code}
> # hooks do not get executed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message