cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10640) Windows logging is broken
Date Wed, 17 Feb 2016 23:08:18 GMT

    [ https://issues.apache.org/jira/browse/CB-10640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151372#comment-15151372
] 

ASF GitHub Bot commented on CB-10640:
-------------------------------------

Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/151#discussion_r53247225
  
    --- Diff: template/cordova/lib/log.js ---
    @@ -47,10 +47,10 @@ var appTracingInitialState = null,
      * and prints them to console
      */
     module.exports.run = function(args) {
    -    var startTime = new Date(new Date().getTime() - 10 * 60 * 1000).toISOString(), //
show last 10 minutes by default
    -        knownOpts = { 'minutes' : Number, 'dump' : Boolean, 'help' : Boolean },
    -        shortHands = { 'mins' : ['--minutes'], 'h' : ['--help'] },
    -        parsedOpts = nopt(knownOpts, shortHands, args, 0);
    +    var startTime  = 10 * 60 * 1000; // show last 10 minutes by default
    --- End diff --
    
    Nitpick: It would be nice to rename startTime to something else. It isn't really a start
time anymore.


> Windows logging is broken
> -------------------------
>
>                 Key: CB-10640
>                 URL: https://issues.apache.org/jira/browse/CB-10640
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Sarangan Rajamanickam
>            Assignee: Sarangan Rajamanickam
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message