cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-10611) --nohooks missed disabling before_plugin_install
Date Mon, 15 Feb 2016 02:08:18 GMT


ASF GitHub Bot commented on CB-10611:

GitHub user bso-intel opened a pull request:

    CB-10611 fixed the before_plugin_install hook not disabled with --noh…

    The fix is to pass the command line option to the plugman when adding a plugin.

You can merge this pull request into a Git repository by running:

    $ git pull CB-10611

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #388
commit aaa2e6143de412a3affba5bba8a4dd092de4a845
Author: Byoungro So <>
Date:   2016-02-15T01:11:40Z

    CB-10611 fixed the before_plugin_install hook not disabled with --nohooks


> --nohooks missed disabling before_plugin_install
> ------------------------------------------------
>                 Key: CB-10611
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Byoungro So
>            Assignee: Byoungro So
> --nohooks option does not disable before_plugin_install hook.
> This was missed from CB-8455.
> Here is the test scenario.
> {code}
> [nohooks-test] cordova plugin add cordova-plugin-device --nohooks .
> Fetching plugin "cordova-plugin-device@~1.1.1" via npm
> Installing "cordova-plugin-device" for ios
> Running command: /Users/bso/cordova/test/nohooks-test/hooks/before_plugin_install/hook.js
> before plugin install hook executed
> {code}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message