cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10586) Cordova Platform Add Windows fires after_prepare hook before plugins are added
Date Fri, 19 Feb 2016 09:42:18 GMT

    [ https://issues.apache.org/jira/browse/CB-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153991#comment-15153991
] 

Vladimir Kotikov commented on CB-10586:
---------------------------------------

[~ryanfio], this has been fixed in https://github.com/apache/cordova-lib/pull/393. Could you
please verify that the issue doesn't reproduce with latest master? Thanks.

> Cordova Platform Add Windows fires after_prepare hook before plugins are added
> ------------------------------------------------------------------------------
>
>                 Key: CB-10586
>                 URL: https://issues.apache.org/jira/browse/CB-10586
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 6.0.0
>            Reporter: Ryan Fiorini
>            Assignee: Vladimir Kotikov
>              Labels: reproduced, triaged
>             Fix For: 6.1.0
>
>
> I have an after_prepare hook that makes changes to a plugin for windows only and when
I do a cordova platform add windows it fails because the prepare hook tries to find the plugin
and it isn't there.  When I put a try catch around it the prepare succeeds and then I see
the plugin add messages.
> This seems like a wrong order of processing when adding the platform.  It seems like
the plugins should be added first then the prepare hook.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message