cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-10498) Resume event not guaranteed to be received with plugin result
Date Thu, 04 Feb 2016 06:16:40 GMT


ASF GitHub Bot commented on CB-10498:

Github user adamduren commented on a diff in the pull request:
    --- Diff: cordova-js-src/platform.js ---
    @@ -58,6 +61,19 @@ module.exports = {
    +        // The resume event is not "sticky", but it is possible that the event
    +        // will contain the result of a plugin call. We need to ensure that the
    +        // plugin result is delivered even after the event is fired (CB-10498)
    +        var cordovaAddEventListener = document.addEventListener;
    --- End diff --
    This is really the original document.addListener. Maybe the name should be changed to
make that more clear.
    I think this is a simple and clean solution. However, I am a little weary about monkey
patching `document.addEventListener`. I'm not sure what a better alternative would be though
without adding unnecessary complexity.

> Resume event not guaranteed to be received with plugin result
> -------------------------------------------------------------
>                 Key: CB-10498
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>            Reporter: Richard B Knoll
>            Assignee: Richard B Knoll
>              Labels: android, triaged
> The save/restore API delivers results in the resume event. The issue is, it is possible
to "miss" the resume event if you don't add an event handler in time.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message