cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10465) cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments
Date Wed, 03 Feb 2016 14:24:39 GMT

    [ https://issues.apache.org/jira/browse/CB-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130454#comment-15130454
] 

ASF GitHub Bot commented on CB-10465:
-------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/374#issuecomment-179263903
  
    LGTM


> cordova.raw.emulate fires a cordova.raw.prepare with incorrect arguments
> ------------------------------------------------------------------------
>
>                 Key: CB-10465
>                 URL: https://issues.apache.org/jira/browse/CB-10465
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.4.1
>            Reporter: Manuel Martiarena
>            Assignee: Vladimir Kotikov
>              Labels: cordova-lib, reproduced, triaged
>
> All cordova.raw command now need to be called with arguments like this ticket expains:
https://issues.apache.org/jira/browse/CB-9987.
> Unfortunately the raw emulate command executes the raw prepare with the wrong structure
of arguments, with the side effect that if you want to emulate only iOS, the other configured
projects will also be add/checked/prepared.
> emulate.js calls it like this: 
> return require('./cordova').raw.prepare(options.platforms);
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/emulate.js
line 36
> But the argument should be an object with a key named platforms. like so:
> return require('./cordova').raw.prepare({platforms: options.platforms}); 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message