cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10405) Connectivity issue to Cordova VM
Date Tue, 02 Feb 2016 22:02:40 GMT

    [ https://issues.apache.org/jira/browse/CB-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129128#comment-15129128
] 

ASF GitHub Bot commented on CB-10405:
-------------------------------------

Github user sarangan12 commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/74#discussion_r51643160
  
    --- Diff: lib/testcheck.js ---
    @@ -21,22 +21,40 @@
     
     "use strict";
     
    -module.exports = function (sha, dbHost) {
    +module.exports = function (sha, dbHost, maxnumberoftries, delay) {
     
         var http = require("http"),
             url = require("url"),
             q = require("q");
     
    +    function tryConnect(options, d, pendingnumberoftries, operation, successCallBack){
    +        http.get(options, successCallBack)
    +            .on("error", function(e){
    +                if(pendingnumberoftries > 1){
    +                    console.log("Connection attempt to " + operation + " failed. Will
try after: " + delay + " milliseconds.");
    --- End diff --
    
    @nikhilkh Logged the e.message and moved the log to use util.medicLog


> Connectivity issue to Cordova VM 
> ---------------------------------
>
>                 Key: CB-10405
>                 URL: https://issues.apache.org/jira/browse/CB-10405
>             Project: Apache Cordova
>          Issue Type: Test
>            Reporter: Sarangan Rajamanickam
>              Labels: found-by-ci, triaged
>
> During Apache Cordova CI, we get errors while checking the cordova VMs. They are intermittent.
So, we need to add retry logic to the code. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message