cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10326) Don't copy `resource-file` files at plugin install time
Date Sat, 13 Feb 2016 09:44:18 GMT

    [ https://issues.apache.org/jira/browse/CB-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145907#comment-15145907
] 

ASF subversion and git services commented on CB-10326:
------------------------------------------------------

Commit 1410f3c3d97425369ea32ec6c05c72ac02b39b75 in cordova-windows's branch refs/heads/master
from [~biasmv]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=1410f3c ]

CB-10326 Don't copy `resource-file` files at plugin install time

Instead, reference the file in the plugin directory. This allows to have multiple
source files map to the same destination file inside the build directory and
choose the appropriate file based on the build configuration, e.g. architecture.

Github close #139


> Don't copy `resource-file` files at plugin install time
> -------------------------------------------------------
>
>                 Key: CB-10326
>                 URL: https://issues.apache.org/jira/browse/CB-10326
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Marco Biasini
>            Assignee: Sergey Grebnov
>
> I just came across the newly added resource-file support for phonegap for windows. I've
tried to use it for adding native dlls dependencies to the application. I couldn't completely
get it to work with the current version.
> I'd like to propose a small change which would make the resource-file tag more powerful
and shouldn't impact existing users:
> Judging from the source code, the file is copied to the target when the plugin is installed.
I'd propose not to copy to the target but to point the include parameter to the existing file.
This allows use-cases where a different .dll has to be copied based on the architecture of
the project, .e.g.
> <resource-file src="x86/foo.dll" arch="x86" />
> <resource-file src="arm/foo.dll" arch="arm" />
> <resource-file src="x64/foo.dll" arch="x64" />
> This should generate code like this for each resource-file entry:
>     <ItemGroup>
>         <Content Condition="'$(Platform)'=='x86'" Include="x86/foo.dll">
>             <Link>foo.dll</Link>
>             <CopyToOutputDirectory>Always</CopyToOutputDirectory>
>         </Content>
>     </ItemGroup>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message