cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-9347) You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused this
Date Fri, 12 Feb 2016 02:37:18 GMT


ASF GitHub Bot commented on CB-9347:

Github user tony-- commented on the pull request:
    @jcesarmobile - With regard to phonegap-plugin-barcodescanner+cordova-plugin-dialogs,
I was chatting with @imaffett about this.  He found that reverting from cordova-plugin-dialogs@1.2.0
to cordova-plugin-dialogs@1.1.1 fixed the issue he was seeing.  I was comparing the code from
the 2 versions and am wondering about [this](
 What should happen when `[alertList count] > 1`?  Maybe I am reading it wrong, but it
seems like the way it is now, it will silently fail.  Is that the intended behavior? Am I
misunderstanding what will happen?  Thanks in advance for help with improving my understanding!

> You can no longer stack alerts in cordova-plugin-dialogs - commit #ee3b02b3 has caused
> -------------------------------------------------------------------------------------------
>                 Key: CB-9347
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Dialogs
>    Affects Versions: 1.1.0
>         Environment: Mac OS X Yosemite 10.10.4; XCode 6.4 iOS
>            Reporter: Kelvin Dart
>            Assignee: jcesarmobile
>            Priority: Critical
> Previously in cordova-plugin-dialogs, you could stack alerts in Cordova like follows:
> {code}
> navigator.notification.alert('Notification 1', function () {}, 'Title 1');
> navigator.notification.alert('Notification 2', function () {}, 'Title 2');
> {code}
> And it would show 'Notification 2' then 'Notification 1'.
> Now you cannot, in commit: #ee3b02b3c78debe608263d847f7ac69bda1bfca0, there was quite
a large overhaul in {{showDialogWithMessage}} in {{CDVNotification.m}}; this commit seems
to add some code for iOS 8.3+ which uses {{UIAlertController}} instead of the old {{UIAlertView}}.
The problem is here - unfortunately I do not know Obj-C too well in order to debug it.
> If you revert to a cordova-plugin-dialogs version prior to this, the stacked notifications
work fine.
> I have created a small test harness which you can download [here|].
> Please could you implement the old behaviour as this has cause some aspects of my app
to break - thanks!
> N.b. I have tagged the version as 1.1.0 as it would not allow me to tag 1.1.1.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message