Return-Path: 
 <issues-return-55986-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org
Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5031118ABD
	for <apmail-cordova-issues-archive@minotaur.apache.org>;
 Mon, 11 Jan 2016 17:35:40 +0000 (UTC)
Received: (qmail 62664 invoked by uid 500); 11 Jan 2016 17:35:40 -0000
Delivered-To: apmail-cordova-issues-archive@cordova.apache.org
Received: (qmail 62635 invoked by uid 500); 11 Jan 2016 17:35:40 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 62411 invoked by uid 99); 11 Jan 2016 17:35:40 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 17:35:40 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id D0AA32C1F5C
	for <issues@cordova.apache.org>; Mon, 11 Jan 2016 17:35:39 +0000 (UTC)
Date: Mon, 11 Jan 2016 17:35:39 +0000 (UTC)
From: "Nikhil Khandelwal (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12925014.1451554114000.75075.1452533739851@Atlassian.JIRA>
In-Reply-To: <JIRA.12925014.1451554114000@Atlassian.JIRA>
References: <JIRA.12925014.1451554114000@Atlassian.JIRA>
 <JIRA.12925014.1451554114422@arcas>
Subject: [jira] [Commented] (CB-10284) Adding plugins seems to be totally
 broken on Cordova 5.4.0 and 5.4.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092343#comment-15092343 ] 

Nikhil Khandelwal commented on CB-10284:
----------------------------------------

>From what I understand, the scenario is to use a new version of Cordova (in this case 5.4.x) to create a project, add plugins etc. and in the future use older version of Cordova (say 5.3.x) to manipulate it.

I agree the scenario is not supported. To add a warning we will have to update older versions of Cordova i.e. 5.3.3. Perhaps when we made this breaking change we should have bumped the major version of the Cordova CLI/lib - however, we did not do that. Perhaps giving a warning here would be a nice improvement for the future.

> Adding plugins seems to be totally broken on Cordova 5.4.0 and 5.4.1
> --------------------------------------------------------------------
>
>                 Key: CB-10284
>                 URL: https://issues.apache.org/jira/browse/CB-10284
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.4.0, 5.4.1
>         Environment: Mac OS X 10.10.5
>            Reporter: Sebastien
>            Assignee: Vladimir Kotikov
>            Priority: Minor
>              Labels: triaged
>
> Using Cordova CLI 5.3.3, try creating a new project and then adding the Android platform and the whitelist plugin (using `$ cordova plugin add cordova-plugin-whitelist@1.2.0`). Then open the _plugins/android.json_ file, its content is:
> {code:javascript|title=plugins/android.json}
> {
>     "prepare_queue": {
>         "installed": [],
>         "uninstalled": []
>     },
>     "config_munge": {
>         "files": {
>             "res/xml/config.xml": {
>                 "parents": {
>                     "/*": [
>                         {
>                             "xml": "<feature name=\"Whitelist\"><param name=\"android-package\" value=\"org.apache.cordova.whitelist.WhitelistPlugin\" /><param name=\"onload\" value=\"true\" /></feature>",
>                             "count": 1
>                         }
>                     ]
>                 }
>             }
>         }
>     },
>     "installed_plugins": {
>         "cordova-plugin-whitelist": {
>             "PACKAGE_NAME": "com.my-app.dev"
>         }
>     },
>     "dependent_plugins": {}
> }
> {code}
> Now start another project using Cordova CLI 5.4.0 or 5.4.1 and do the same exact thing. The file content is:
> {code:javascript|title=plugins/android.json}
> {
>     "prepare_queue": {
>         "installed": [],
>         "uninstalled": []
>     },
>     "config_munge": {
>         "files": {}
>     },
>     "installed_plugins": {
>         "cordova-plugin-whitelist": {
>             "PACKAGE_NAME": "com.my-app.dev"
>         }
>     },
>     "dependent_plugins": {}
> }
> {code}
> Notice that `config_munge.files` is empty. This is a major regression as plugins using this feature don't work at all sometimes even preventing the `deviceready` event to be triggered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org