Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6095518295 for ; Sat, 9 Jan 2016 01:13:40 +0000 (UTC) Received: (qmail 50468 invoked by uid 500); 9 Jan 2016 01:13:40 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 50440 invoked by uid 500); 9 Jan 2016 01:13:40 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 50276 invoked by uid 99); 9 Jan 2016 01:13:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jan 2016 01:13:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C9F292C14F4 for ; Sat, 9 Jan 2016 01:13:39 +0000 (UTC) Date: Sat, 9 Jan 2016 01:13:39 +0000 (UTC) From: "Nikhil Khandelwal (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CB-9007) main run loop for cordova-cli can hit error handler with empty error, which isn't logged MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Khandelwal updated CB-9007: ---------------------------------- Priority: Minor (was: Critical) > main run loop for cordova-cli can hit error handler with empty error, which isn't logged > ---------------------------------------------------------------------------------------- > > Key: CB-9007 > URL: https://issues.apache.org/jira/browse/CB-9007 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib > Affects Versions: 5.0.0 > Environment: OS X 10.10, cordova-ios added to project, ios-deploy version 1.3.2 > Reporter: Jenny Gee > Priority: Minor > Attachments: ios-deploy > > > iPhone 5 running iOS 8.3 connected via lightning cable to MBP > {quote} > $ /Users/jgee/REPOS/SCW/web-app/platforms/ios/cordova/run --device > {quote} > actual results: > no output. > with debugging, we see: > {{get_ios_deploy_version}}'s ({{versions.js}}) child process error callback is called with: > {code} > error = { [Error: Command failed: ] killed: false, code: 253, signal: null } > stderr = "" > stdout = "1.3.2" > {code} > The root cause for this is: > {quote} > $ ios-deploy --version ; echo $? > 1.3.2 > 253 > {quote} > expected results: > 1. when the main run path in cordova-cli runs: > {code} > if (['--help', '/?', '-h', 'help', '-help', '/help'].indexOf(args[2]) > -1) { > run.help(); > } else { > run.run(args).done(function() { > console.log('** RUN SUCCEEDED **'); > }, function (err) { > var errorMessage = (err && err.stack) ? err.stack : err; > console.error(errorMessage); > process.exit(2); > }); > } > {code} > the err handler case needs to complain loudly and clearly if it manages to be called with an empty error, as here. > 2. {{versions.js}} {{get_ios_deploy_version}} exec handler should perhaps handle the case where it gets stdout of a nice version number but for whatever reason the app exits with code {{253}} instead of {{0}}. > 3. {{ios-deploy}} should really not return exit code {{253}} when it's able to spit out a version number. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org