Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 19 Jan 2016 18:40:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12745211.1412156124000.150167.1453228839947@Atlassian.JIRA>
In-Reply-To: <JIRA.12745211.1412156124000@Atlassian.JIRA>
References: <JIRA.12745211.1412156124000@Atlassian.JIRA>
 <JIRA.12745211.1412156124365@arcas>
Subject: [jira] [Commented] (CB-7679) [InAppBrowser][iOS 8] Plugin closes
 itself before image picker shown
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107159#comment-15107159 ] 

ASF GitHub Bot commented on CB-7679:
------------------------------------

GitHub user birge opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/139

    Add fix for iOS file upload.

    I'd like to start by saying I don't understand fully what the issue is or how this fixes the issue. I have been having an issue where my cordova app would fall back to the splash screen when I tried to upload a file on iOS. I found the solution here https://issues.apache.org/jira/browse/CB-7679 
    
    This is before the fix
    ![file_upload_bug](https://cloud.githubusercontent.com/assets/1206124/12428174/04e7daa0-be98-11e5-85bb-2f58bebcad7e.gif)
    
    and this is after
    ![file_upload_bug_fixed](https://cloud.githubusercontent.com/assets/1206124/12428184/0f049848-be98-11e5-81d6-ac2286210036.gif)
    
    I am not sure why this fix wasn't already included so I am hoping it just because no one has taken the time to make a PR. Any issues with this?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/birge/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #139
    
----
commit 651d3cdff3446c7fe16ab3ed866fd194c6f7fd97
Author: Birge Clark <biclark@zendesk.com>
Date:   2016-01-19T18:31:28Z

    add fix for iOS upload

----


> [InAppBrowser][iOS 8] Plugin closes itself before image picker shown
> --------------------------------------------------------------------
>
>                 Key: CB-7679
>                 URL: https://issues.apache.org/jira/browse/CB-7679
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Plugin InAppBrowser
>    Affects Versions: 3.5.0
>         Environment: IOS8,Cordova Plugin
>            Reporter: Nattapol Taboonma
>              Labels: Triaged, iOS
>
> I use inappbrowser plugin from the following link : https://github.com/apache/cordova-plugin-inappbrowser
> Firstly,I open the Disqus on the inapp browser and it perform perfectly fine. Unfortunately, when I click the upload photo icon, then the 2 native buttons will show up. The buttons are 'Take Photo' and 'Choose Existing'. No matter buttons I tapped, the inappbrowser close immediately, and it lead to error 
> Warning: Attempt to present <UIImagePickerController: 0x17aed600> on <CDVInAppBrowserNavigationController: 0x175e3770> whose view is not in the window hierarchy!
> After that, the inappbrowser seem to broke permanently. I have to close and re-start my app to make it work again.
> For more info, I already try the tutorial from this: http://www.codepool.biz/tech-frontier/html5/take-a-photo-and-upload-it-on-mobile-phones-with-html5.html
> with out the inappbrowser the image ui picker work perfectly fine, it surely that the error not come from the image select code, but it from the inappbrowser itself.
> I'm waiting for hearing from you.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org