cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10451) InAppBrowser: loadstart event is not triggered on Windows
Date Thu, 28 Jan 2016 17:22:39 GMT

    [ https://issues.apache.org/jira/browse/CB-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121923#comment-15121923
] 

ASF GitHub Bot commented on CB-10451:
-------------------------------------

Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176290461
  
    LGTM. Looks like these bugs have been there for a while and this is not a recent regression
that this change is addressing.


> InAppBrowser: loadstart event is not triggered on Windows
> ---------------------------------------------------------
>
>                 Key: CB-10451
>                 URL: https://issues.apache.org/jira/browse/CB-10451
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: Windows, triaged
>
> The following unit test fails as 'loadstart' callback is not called on Windows. Main
reason is that it is called internally when we do open before we attach event handler. But
this is what docs recommend and what other people uses. We should make open method async (Windows
proxy or inappbrowser.js) so that handler could be added this way
> {code}
> it("inappbrowser.spec.4 should support loadstart and loadstop events", function (done)
{
>             var onLoadStart = jasmine.createSpy('loadstart event callback').and.callFake(function
(evt) {
>                 verifyEvent(evt, 'loadstart');
>             });
>             iabInsance = cordova.InAppBrowser.open(url, '_blank');
>             iabInsance.addEventListener('loadstart', onLoadStart);
>             iabInsance.addEventListener('loadstop', function (evt) {
>                 verifyEvent(evt, 'loadstop');
>                 expect(onLoadStart).toHaveBeenCalled();
>                 done();
>             });
>         });
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message