cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10440) Add CSS color names support for BackgroundColor on Windows
Date Tue, 26 Jan 2016 08:38:39 GMT

    [ https://issues.apache.org/jira/browse/CB-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116927#comment-15116927
] 

ASF GitHub Bot commented on CB-10440:
-------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/142

    CB-10440 Add CSS color names support for BackgroundColor on Windows

    [Jira issue](https://issues.apache.org/jira/browse/CB-10440)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-windows CB-10440

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit 7134e23633bc0c18b4df31f688098c656c0b1648
Author: daserge <v-seshak@microsoft.com>
Date:   2016-01-26T08:32:16Z

    CB-10440 Add CSS color names support for BackgroundColor on Windows

----


> Add CSS color names support for BackgroundColor on Windows
> ----------------------------------------------------------
>
>                 Key: CB-10440
>                 URL: https://issues.apache.org/jira/browse/CB-10440
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>
> 1. Create a new Cordova project
> 2. Open config.xml
> 3. Add <preference name="BackgroundColor" value="transparent"/> to the file.
> 4. Build for Windows platform
>  Actual:
> APPX3037
> App manifest validation failed. Value '#transparent' of attribute '/Package/Applications/Application/m3:VisualElements/@BackgroundColor'
is not a valid color name or color hexadecimal identifier.
> 	
> This is because the generated appmanifest has this line :
> <uap:VisualElements BackgroundColor="#transparent"  ... />
> where it doesn't expect the value to be a named color value other than a hexadecimal
color value.
> Expected:
> The appmanifest file can be generated correctly, with a value like:
> <uap:VisualElements BackgroundColor="transparent"  ... />
> or
> <uap:VisualElements BackgroundColor="turquoise"  ... />



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message