cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10394) config-file changes are not written to package.windows.appxmanifest
Date Tue, 26 Jan 2016 18:40:39 GMT

    [ https://issues.apache.org/jira/browse/CB-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117714#comment-15117714
] 

ASF GitHub Bot commented on CB-10394:
-------------------------------------

Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-windows/pull/143#issuecomment-175166044
  
    This design seems to be problematic - From what I understand, there are multiple places
where we could be reading and writing a manifest. One of them caches them and hence, can lead
to writing stale data. 
    
    One idea is to validate that we never overwrite manifest changes when we write to disk
- however, it can detect failure but not recover from it. 


> config-file changes are not written to package.windows.appxmanifest
> -------------------------------------------------------------------
>
>                 Key: CB-10394
>                 URL: https://issues.apache.org/jira/browse/CB-10394
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: 4.3.0
>            Reporter: Marco Biasini
>            Assignee: Vladimir Kotikov
>              Labels: regression, triaged
>
> I've noticed that config-file changes defined in a plugin are not correctly written to
package.windows.appxmanifest file. After a plugin import, the file does not contain these
changes. The changes are correctly applied to the other appxmanifest files (phone, windows10,
windows80). 
> I've bested both with windows platform 4.3.0 as well as master and the problem exists
in both branches.
> The problem is related to the appxmanifest caching mechanism. The package.windows.appxmanifest
file is loaded early on to determine the package name (through jsprojManager.getPackageName()).
The appxmanifest content is then cached in memory. Then, the config-file changes defined in
the plugin.xml file are applied to the manifests and written to disk. They do not use the
cached manifests from the earlier step,but rather load the files through a different code
path. After that all previously cached appxmanifest instances are then written to disk, which
effectively overwrites the content of package.windows.appxmanifest. Since this is the only
manifest that gets loaded early on, this does not affect the other appxmanifest files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message