cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10367) Add meaningful names to heading anchors in Docs & show a link icon on hover
Date Tue, 19 Jan 2016 20:32:39 GMT

    [ https://issues.apache.org/jira/browse/CB-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107379#comment-15107379
] 

ASF GitHub Bot commented on CB-10367:
-------------------------------------

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/457#discussion_r50170880
  
    --- Diff: www/static/js/docs.js ---
    @@ -48,7 +57,10 @@ $(document).ready(function () {
                 // add a special class to the anchor for this toc entry
                 var anchorName = getAnchorName(i, heading, prefix);
                 $('#' + anchorName).addClass('fragment-anchor');
    -
    +            if (i > 0) { 
    --- End diff --
    
    Should we also apply this condition to the above adding of `'fragment-anchor'`?


> Add meaningful names to heading anchors in Docs & show a link icon on hover
> ---------------------------------------------------------------------------
>
>                 Key: CB-10367
>                 URL: https://issues.apache.org/jira/browse/CB-10367
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Docs
>            Reporter: Nikhil Khandelwal
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message