cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10305) Gray bar appears in the wrong place
Date Sat, 16 Jan 2016 10:55:39 GMT

    [ https://issues.apache.org/jira/browse/CB-10305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103109#comment-15103109
] 

ASF GitHub Bot commented on CB-10305:
-------------------------------------

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/137

    Fix for CB-10305

    There are really 3 issues here.
    1. When the inAppBrowser is started in portrait and rotates, the
    background of the status bar doesn’t fill the whole area. (any iOS
    version)
    2. On iOS 7, if the inAppBrowser plugin is started on landscape, the
    background of the status bar was vertical.
    3. On iOS 8-9, on iPhone/iPod, the status bar disappears on landscape,
    but the background doesn’t disappear. I’ve changed it to make the
    status bar appear  on landscape too. (This wasn’t on CB-10305, but I
    think it’s related)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-10368

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 500de94ae968f77c4545f8e6222eac543caf5ef4
Author: Julio César <jcesarmobile@gmail.com>
Date:   2016-01-16T10:45:17Z

    Fix for CB-10305
    
    There are really 3 issues here.
    1. When the inAppBrowser is started in portrait and rotates, the
    background of the status bar doesn’t fill the whole area. (any iOS
    version)
    2. On iOS 7, if the inAppBrowser plugin is started on landscape, the
    background of the status bar was vertical.
    3. On iOS 8-9, on iPhone/iPod, the status bar disappears on landscape,
    but the background doesn’t disappear. I’ve changed it to make the
    status bar appear  on landscape too. (This wasn’t on CB-10305, but I
    think it’s related)

----


> Gray bar appears in the wrong place
> -----------------------------------
>
>                 Key: CB-10305
>                 URL: https://issues.apache.org/jira/browse/CB-10305
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser
>    Affects Versions: 3.9.0
>            Reporter: Jacob Weber
>            Assignee: jcesarmobile
>              Labels: iOS
>         Attachments: CordovaTest.zip, screen-1.png, screen-2.png, screen-3.png
>
>
> I'm seeing several issues on iOS with the gray semi-transparent overlay that appears
behind the status bar, when the InAppBrowser window is open.
> On Mac OS 10.11.2, create a project as follows (or use the attached CordovaTest project):
> {code}
> cordova --version   # prints 5.3.3
> cordova create CordovaTest com.jacobweber.cordovatest CordovaTest
> cd CordovaTest
> cordova platform add ios
> cordova plugin add cordova-plugin-inappbrowser
> platforms/ios/cordova/version   # prints 3.9.2
> {code}
> Edit {{platforms/ios/www/js/index.js}}, and add the following code at the end of {{onDeviceReady}}:
> {code}
> setTimeout(function(){
>   window.open("https://www.google.com", "_blank");
> }, 1000);
> {code}
> In Xcode, go to General > Deployment Info > iPad > Device Orientation, and check
all boxes.
> h4. Issue 1:
> * Open the Xcode project on Mac OS 10.11.2 using Xcode 7.2.
> * Launch on iPad Air simulator with iOS 9.2.
> * Launch in portrait, and wait for the window to open. Rotate to landscape. The gray
status bar doesn't extend all the way to the right. See screen-1.png.
> h4. Issue 2:
> * Open the Xcode project on Mac OS 10.10 using Xcode 6.2 (since El Capitan can't launch
an iOS 7 simulator).
> * Launch on iPad Air simulator with iOS 7.1.
> * Launch in landscape, and wait for the window to open. The gray status bar appears on
the left side. Rotate to portrait. The gray status bar is still on the left. See screen-2.png.
> h4. Issue 3:
> * Keep the iOS 7.1 simulator open. Launch a second time in landscape, and wait for the
window to open. Some of the time, the gray status bar appears vertically in the middle of
the screen. See screen-3.png.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message