cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10102) statusbar removeObserver is wrong
Date Mon, 18 Jan 2016 18:44:39 GMT

    [ https://issues.apache.org/jira/browse/CB-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105642#comment-15105642
] 

ASF GitHub Bot commented on CB-10102:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-statusbar/pull/45


> statusbar removeObserver is wrong
> ---------------------------------
>
>                 Key: CB-10102
>                 URL: https://issues.apache.org/jira/browse/CB-10102
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Statusbar
>         Environment: iOS
>            Reporter: jcesarmobile
>            Assignee: jcesarmobile
>            Priority: Minor
>
> The current code is wrong
> {code}[[NSNotificationCenter defaultCenter] removeObserver:self forKeyPath:UIApplicationDidChangeStatusBarFrameNotification];
> {code}
> It should be
> {code}
> [[NSNotificationCenter defaultCenter]removeObserver:self name:UIApplicationDidChangeStatusBarOrientationNotification
object:nil];
> {code}
> It might crash on plugin dealocation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message