cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10102) statusbar removeObserver is wrong
Date Sat, 16 Jan 2016 19:24:39 GMT

    [ https://issues.apache.org/jira/browse/CB-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103399#comment-15103399
] 

ASF GitHub Bot commented on CB-10102:
-------------------------------------

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/45

    Fix for CB-10102

    The removeObserver code was wrong and it might crash on plugin
    deallocation

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar CB-10102

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #45
    
----
commit 082c385dbcd83a0a2bfda5e23a788eff77f7e66f
Author: Julio C├ęsar <jcesarmobile@gmail.com>
Date:   2016-01-16T19:23:36Z

    Fix for CB-10102
    
    The removeObserver code was wrong and it might crash on plugin
    deallocation

----


> statusbar removeObserver is wrong
> ---------------------------------
>
>                 Key: CB-10102
>                 URL: https://issues.apache.org/jira/browse/CB-10102
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Statusbar
>         Environment: iOS
>            Reporter: jcesarmobile
>            Assignee: jcesarmobile
>            Priority: Minor
>
> The current code is wrong
> {code}[[NSNotificationCenter defaultCenter] removeObserver:self forKeyPath:UIApplicationDidChangeStatusBarFrameNotification];
> {code}
> It should be
> {code}
> [[NSNotificationCenter defaultCenter]removeObserver:self name:UIApplicationDidChangeStatusBarOrientationNotification
object:nil];
> {code}
> It might crash on plugin dealocation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message