cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jcesarmobile (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-8001) StatusBar Plugin 0.1.8 crashes application on tap
Date Tue, 12 Jan 2016 14:04:39 GMT

    [ https://issues.apache.org/jira/browse/CB-8001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093903#comment-15093903
] 

jcesarmobile edited comment on CB-8001 at 1/12/16 2:04 PM:
-----------------------------------------------------------

I talked about this issue with [~shazron] on slack, but I can't find the conversation.
If I remember correctly, I think he said that making the callbackId as a @property might fix
the issue, but I think I tried and didn't work.

It should be possible to make it compatible with both using preprocessor macros, something
like this:

{code}
#if __has_feature(objc_arc)
    _eventsCallbackId = command.callbackId;
#else
    _eventsCallbackId = [command.callbackId retain];
#endif
{code}


was (Author: jcesarmobile):
I talked about this issue with [~shazron] on slack, but I can't find the conversation.
If I remember correctly, I think he said that making the callbackId as a @property might fix
the issue, but I think I tried and didn't work.

It should be possible to make it compatible with both using pre processors, something like
this:

{code}
#if __has_feature(objc_arc)
    _eventsCallbackId = command.callbackId;
#else
    _eventsCallbackId = [command.callbackId retain];
#endif
{code}

> StatusBar Plugin 0.1.8 crashes application on tap
> -------------------------------------------------
>
>                 Key: CB-8001
>                 URL: https://issues.apache.org/jira/browse/CB-8001
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Statusbar
>    Affects Versions: 3.7.0
>         Environment: StatusBar Plugin 0.1.8
> Cordova iOS 3.7.0
> iPhone 6+ (8.0)
> iPhone 5s (8.0)
>            Reporter: Nathan Smith
>            Priority: Critical
>              Labels: iOS, triaged
>         Attachments: status-bar-test.zip
>
>
> StatusBar Plugin 0.1.8
> Cordova iOS 3.7.0
> iPhone 6+ (8.0)
> iPhone 5s (8.0)
> The StatusBar encounters an {{EXC_BAD_ACCESS}} exception when the user taps on the StatusBar.
> The call site affected is {{fireTappedEvent}} {{\[self.commandDelegate sendPluginResult:result
callbackId:_eventsCallbackId\];}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message