Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 484EC189FB for ; Wed, 9 Dec 2015 03:39:11 +0000 (UTC) Received: (qmail 24825 invoked by uid 500); 9 Dec 2015 03:39:11 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 24792 invoked by uid 500); 9 Dec 2015 03:39:11 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 24756 invoked by uid 99); 9 Dec 2015 03:39:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Dec 2015 03:39:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id EFDAF2C14F7 for ; Wed, 9 Dec 2015 03:39:10 +0000 (UTC) Date: Wed, 9 Dec 2015 03:39:10 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-10162) [iOS] icon and splashscreen images don't copy over correctly from template MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047967#comment-15047967 ] ASF GitHub Bot commented on CB-10162: ------------------------------------- Github user csantanapr commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/182#discussion_r47048069 --- Diff: bin/templates/scripts/cordova/lib/prepare.js --- @@ -47,8 +47,8 @@ module.exports.prepare = function (cordovaProject) { return updateProject(self._config, self.locations); }) .then(function () { - handleIcons(cordovaProject.projectConfig, self.root); - handleSplashScreens(cordovaProject.projectConfig, self.root); + handleIcons(cordovaProject.projectConfig, self.root, self.locations); --- End diff -- @eymorale instead of passing self.locations, pass the directory to use handleIcons(cordovaProject.projectConfig, self.locations.xcodeCordovaProj); handleSplashScreens(cordovaProject.projectConfig, self.locations.xcodeCordovaProj); then no need to do basename or create new variable originalName > [iOS] icon and splashscreen images don't copy over correctly from template > -------------------------------------------------------------------------- > > Key: CB-10162 > URL: https://issues.apache.org/jira/browse/CB-10162 > Project: Apache Cordova > Issue Type: Bug > Components: iOS > Affects Versions: Master > Environment: iOS > Reporter: Edna Morales > Assignee: Edna Morales > > When specifying paths for splashscreen and icon images in config.xml, they do not get copied over to the iOS project due to incorrect paths in the prepare script for iOS -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org