Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BBC7218415 for ; Wed, 16 Dec 2015 23:30:47 +0000 (UTC) Received: (qmail 27136 invoked by uid 500); 16 Dec 2015 23:30:47 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 27092 invoked by uid 500); 16 Dec 2015 23:30:47 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 26722 invoked by uid 99); 16 Dec 2015 23:30:47 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Dec 2015 23:30:47 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3D9D32C1F73 for ; Wed, 16 Dec 2015 23:30:47 +0000 (UTC) Date: Wed, 16 Dec 2015 23:30:47 +0000 (UTC) From: "Shazron Abdullah (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CB-4071) Capture error callback (should be an object) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shazron Abdullah updated CB-4071: --------------------------------- Component/s: (was: iOS) > Capture error callback (should be an object) > -------------------------------------------- > > Key: CB-4071 > URL: https://issues.apache.org/jira/browse/CB-4071 > Project: Apache Cordova > Issue Type: Bug > Components: Android, Docs, Plugin Media Capture, Windows 8 > Affects Versions: 2.9.0 > Environment: All > Reporter: Jonathan Bond > Priority: Minor > > When using camera.getPicture(), the cameraError is documented as a string but on Android & iOS, it's actually an object. > On the native side in 2.7: > Android: > private static final int CAPTURE_INTERNAL_ERR = 0; > // private static final int CAPTURE_APPLICATION_BUSY = 1; > // private static final int CAPTURE_INVALID_ARGUMENT = 2; > > private static final int CAPTURE_NO_MEDIA_FILES = 3; > iOS: > enum CDVCaptureError { > > CAPTURE_INTERNAL_ERR = 0, > > CAPTURE_APPLICATION_BUSY = 1, > > CAPTURE_INVALID_ARGUMENT = 2, > > CAPTURE_NO_MEDIA_FILES = 3, > > CAPTURE_NOT_SUPPORTED = 20 > }; > Windows 8: > only string errors > Android and iOS have the same looking api on the native side, error callback Android returns JSON: {message: '', code: int}, iOS returns JSON: {message: '', status: int}, > Looking at the javascript api, it looks like it should return a 'new CaptureError()' on the errorCallback, is that the direction for 3.0? > Windows only sends a string as the callback error, it's difficult to know if the user just cancelled taking a picture or what kind of specific error occurred. > Should I look into creating a patch? > This probably affects other apis, overall I'd like to see the CaptureError() returned more consistently instead of strings. > It would make sense to improve this in 3.0 and possibly break BC for those expecting strings. > CaptureError() could implement 'toString()' to mitigate potential issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org