cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10255) Add options to hide splashscreen navigation and status bars on Android
Date Wed, 23 Dec 2015 19:34:46 GMT

    [ https://issues.apache.org/jira/browse/CB-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070079#comment-15070079
] 

ASF GitHub Bot commented on CB-10255:
-------------------------------------

Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r48373317
  
    --- Diff: src/android/SplashScreen.java ---
    @@ -255,6 +259,10 @@ public void run() {
                     }
                     splashDialog.setContentView(splashImageView);
                     splashDialog.setCancelable(false);
    +                if (isForceFullScreen()) {
    --- End diff --
    
    Does it make sense to move this to `// check to see if the splash screen should be full
screen` condition above?


> Add options to hide splashscreen navigation and status bars on Android
> ----------------------------------------------------------------------
>
>                 Key: CB-10255
>                 URL: https://issues.apache.org/jira/browse/CB-10255
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin SplashScreen
>            Reporter: Sergey Shakhnazarov
>              Labels: android
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message