cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10204) Fix getCurrentPosition options on Android
Date Wed, 30 Dec 2015 10:18:49 GMT

    [ https://issues.apache.org/jira/browse/CB-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074906#comment-15074906
] 

ASF GitHub Bot commented on CB-10204:
-------------------------------------

Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/60#issuecomment-167973027
  
    LGTM


> Fix getCurrentPosition options on Android
> -----------------------------------------
>
>                 Key: CB-10204
>                 URL: https://issues.apache.org/jira/browse/CB-10204
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Geolocation
>         Environment: Cordova 3.5.0, Plugin Geolocation 2.0.0
>            Reporter: Timo Salola
>            Assignee: Sergey Grebnov
>              Labels: Android, Triaged
>
> In the latest release there was created separate JS file for android. In getCurrentPosition
it does not verify that options are given resulting javascript error when trying to access
undefined as an array at www/android/geolocation.js lines 33 and 34:
> {code:javascript}
>     getCurrentPosition: function(success, error, args) {
>         var win = function() {
>           var geo = cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
>           geo.getCurrentPosition(success, error, {
>             enableHighAccuracy: args[0],
>             maximumAge: args[1]
>           });
>         };
>         exec(win, error, "Geolocation", "getPermission", []);
>     }
> {code}
> Workaround this is to give empty array to getCurrentPosition as options:
> {code:javascript}
> navigator.geolocation.getCurrentPosition(onSuccess, onError, []);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message