cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Bowser (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-9949) Menu button event not fired in Android
Date Mon, 21 Dec 2015 04:06:46 GMT

    [ https://issues.apache.org/jira/browse/CB-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066029#comment-15066029
] 

Joe Bowser edited comment on CB-9949 at 12/21/15 4:06 AM:
----------------------------------------------------------

[~marfire] Yeah, I know it's about the menu button, which I said in the other thread we shouldn't
even support.  Given that this hasn't even worked for a major version, I'm fine with changing
the API when someone actually sends a pull request through github.

As I said before, patches are welcome and someone actually sent a pull request, which I decided
to accept instead of code in a JIRA issue.  If you wish to send a pull request to make this
conform to the API, feel free to do so.

And yeah, I should have said your app.  It's the project's API, and I'm fine breaking it in
this circumstance since it's something that didn't even work on a major version and someone
provided a pull request.  Patches, such as the one that was provided here, are welcome.



was (Author: bowserj):
[~marfire] Yeah, I know it's about the menu button, which I said in the other thread we shouldn't
even support.  Given that this hasn't even worked for a major version, I'm fine with changing
the API when someone actually sends a pull request through github.

As I said before, patches are welcome and someone actually sent a pull request, which I decided
to accept instead of code in a JIRA issue.  If you wish to send a pull request to make this
conform to the API, feel free to do so.

And yeah, I should have said your app.  It's the project's API, and I'm fine breaking it if
it's something that didn't even work on a major version if someone provides a pull request.

> Menu button event not fired in Android
> --------------------------------------
>
>                 Key: CB-9949
>                 URL: https://issues.apache.org/jira/browse/CB-9949
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 5.3.2
>            Reporter: Keith Wong
>            Assignee: Joe Bowser
>         Attachments: cordova-android.patch
>
>
> The menu button event handler is not called when the menu button is pressed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message