Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D44718B6C for ; Fri, 6 Nov 2015 02:34:28 +0000 (UTC) Received: (qmail 68744 invoked by uid 500); 6 Nov 2015 02:34:28 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 68731 invoked by uid 500); 6 Nov 2015 02:34:28 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 68720 invoked by uid 99); 6 Nov 2015 02:34:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Nov 2015 02:34:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B84BD2C1F5E for ; Fri, 6 Nov 2015 02:34:27 +0000 (UTC) Date: Fri, 6 Nov 2015 02:34:27 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-9883) Remove unused iOS bridges MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992966#comment-14992966 ] ASF GitHub Bot commented on CB-9883: ------------------------------------ Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526 @shazron is this a lesson learned that certain experimental things should be kept in experimental branches and not in master :+1: > Remove unused iOS bridges > ------------------------- > > Key: CB-9883 > URL: https://issues.apache.org/jira/browse/CB-9883 > Project: Apache Cordova > Issue Type: Bug > Components: iOS > Reporter: Shazron Abdullah > Assignee: Shazron Abdullah > Labels: cordova-ios-4.0.x > > We have 7 bridges in iOS: > https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L36-L43 > IFRAME_NAV is the default, and is actively used. > WK_WEBVIEW_BINDING will be used by the wkwebview-engine plugin, > although I really want the plugin itself to inject this, haven't > explored that yet. > Remove these bridges: > https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L38-L42 > XHR_NO_PAYLOAD > XHR_WITH_PAYLOAD > XHR_OPTIONAL_PAYLOAD > IFRAME_HASH_NO_PAYLOAD > IFRAME_HASH_WITH_PAYLOAD > ... and their associated native code. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org