Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3F2718191 for ; Mon, 23 Nov 2015 18:09:11 +0000 (UTC) Received: (qmail 35915 invoked by uid 500); 23 Nov 2015 18:09:11 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 35398 invoked by uid 500); 23 Nov 2015 18:09:11 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 35100 invoked by uid 99); 23 Nov 2015 18:09:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2015 18:09:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1184F2C1F5B for ; Mon, 23 Nov 2015 18:09:11 +0000 (UTC) Date: Mon, 23 Nov 2015 18:09:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-8156) [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022617#comment-15022617 ] ASF GitHub Bot commented on CB-8156: ------------------------------------ Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/84#discussion_r45637648 --- Diff: src/android/ContactManager.java --- @@ -52,6 +52,7 @@ Licensed to the Apache Software Foundation (ASF) under one public static final int PENDING_OPERATION_ERROR = 3; public static final int IO_ERROR = 4; public static final int NOT_SUPPORTED_ERROR = 5; + public static final int OPERATION_CANCELLED_ERROR = 5; --- End diff -- Isn't this supposed to be 6 as above, so below? > [Contacts] Cancelling pickContact should call the error callback, but callback "nothing" for now > ------------------------------------------------------------------------------------------------ > > Key: CB-8156 > URL: https://issues.apache.org/jira/browse/CB-8156 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts > Environment: I using ipad mini 8.1.2 with phonegap 3.6.3 or 3.7.1 and latest contact plugin > Reporter: Colin Bau > Assignee: Vladimir Kotikov > Labels: android, ios, regression, reproduced, triaged > > according to this > https://issues.apache.org/jira/browse/CB-7772 > it have been solved > Cancelling pickContact should call the error callback, but callback "nothing" (no any response) for now -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org