Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 30 Nov 2015 16:41:11 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12723130.1403532550000.222297.1448901671175@Atlassian.JIRA>
In-Reply-To: <JIRA.12723130.1403532550000@Atlassian.JIRA>
References: <JIRA.12723130.1403532550000@Atlassian.JIRA>
 <JIRA.12723130.1403532550650@arcas>
Subject: [jira] [Commented] (CB-7006) Empty file is created on file transfer
 if server response is 304.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032050#comment-15032050 ] 

ASF subversion and git services commented on CB-7006:
-----------------------------------------------------

Commit 73223a7d451f3dfb81102d906598ca5bca24eaad in cordova-plugin-file-transfer's branch refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=73223a7 ]

CB-7006 Empty file is created on file transfer if server response is 304

Adds a corresponding test.
Fixes the Windows proxy to not to delete the existing file in case of a download error (including 304) - a temporary file is deleted instead.


> Empty file is created on file transfer if server response is 304.
> -----------------------------------------------------------------
>
>                 Key: CB-7006
>                 URL: https://issues.apache.org/jira/browse/CB-7006
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>         Environment: Android 4.3, cordova 3.4.1, plugin-file-transfer r0.4.4
>            Reporter: Romain Garrigues
>
> Hi,
> I want to use file transfer plugin with "If-Modified-Since" HTTP header.
> When receiving 304 status code from server (file not changed), It seems that file transfer plugin overwrites the current file on device by... new empty one.
> As plugin does not verify HTTP response status code, and HTTP 304 response contains an empty body content, maybe that's a point to check to avoid overwriting already present data ?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org