cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-9975) No longer able to use "all" as orientation for ios
Date Fri, 13 Nov 2015 00:16:11 GMT

    [ https://issues.apache.org/jira/browse/CB-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003273#comment-15003273
] 

Shazron Abdullah edited comment on CB-9975 at 11/13/15 12:15 AM:
-----------------------------------------------------------------

This: https://github.com/apache/cordova-lib/blob/cc1ab409f64e16a06b5b495dd7b5bdfac37acda7/cordova-lib/src/cordova/metadata/parserhelper/preferences.js#L75

The problem is "all" is not a global orientation (as in all platforms), only iOS. Need to
create a new check for isPlatformSpecificOrientation(globalOrientation, platform).


was (Author: shazron):
This: https://github.com/apache/cordova-lib/blob/cc1ab409f64e16a06b5b495dd7b5bdfac37acda7/cordova-lib/src/cordova/metadata/parserhelper/preferences.js#L75

The problem is "all" is not a global orientation (as in all platforms). Need to create a new
check for isPlatformSpecificOrientation(globalOrientation, platform).

> No longer able to use "all" as orientation for ios
> --------------------------------------------------
>
>                 Key: CB-9975
>                 URL: https://issues.apache.org/jira/browse/CB-9975
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Raymond Camden
>            Assignee: Shazron Abdullah
>            Priority: Trivial
>
> Yesterday I blogged about iOS and orientation
> (http://www.raymondcamden.com/2015/11/09/cordova-ios-and-orientation-wondering-why-it-is-locked).
Today on Twitter someone noticed that when they set orientation now, they get an error in
the CLI. I updated my CLI to the latest, and can confirm it is now broken. If you set ios
orientation to all, you get:
> Unsupported global orientation: all
> Defaulting to value: default
> This is obviously wrong on two accounts - it wasn't a global orientation (it was ios
only) and all should be supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message