cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9960) Images from Google Photos cause FileNotFoundException
Date Fri, 06 Nov 2015 01:20:27 GMT

    [ https://issues.apache.org/jira/browse/CB-9960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992870#comment-14992870
] 

ASF GitHub Bot commented on CB-9960:
------------------------------------

Github user jasongin commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/135#discussion_r44093710
  
    --- Diff: src/android/CameraLauncher.java ---
    @@ -547,7 +547,7 @@ private String ouputModifiedBitmap(Bitmap bitmap, Uri uri) throws
IOException {
             String realPath = FileHelper.getRealPath(uri, this.cordova);
     
             // Get filename from uri
    -        String fileName = realPath != null ?
    +        String fileName = realPath != null && !realPath.isEmpty() ?
    --- End diff --
    
    Looks like TextUtils.isEmpty is not currently used anywhere in Cordova Android code, so
I'm OK with leaving this as-is.


> Images from Google Photos cause FileNotFoundException
> -----------------------------------------------------
>
>                 Key: CB-9960
>                 URL: https://issues.apache.org/jira/browse/CB-9960
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>         Environment: Android 6.0, cordova-android 5.0.0 (dev), cordova-plugin-camera
1.2.1 (dev)
>            Reporter: Richard B Knoll
>            Assignee: Richard B Knoll
>              Labels: android
>
> When selecting images from the PHOTOLIBRARY source using the Google Photos application
a FileNotFoundException is thrown if any flags that cause image edits are turned on (width/height,
allowEdit, correctOrientation, etc.). The issue is that our method for dereferencing content
URIs in FileHelper fails for the content URI returned by Google Photos and returns an empty
path (that {{ouputModifiedBitmap()}} tries to grab a filename from)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message