cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9883) Remove unused iOS bridges
Date Wed, 11 Nov 2015 00:37:11 GMT

    [ https://issues.apache.org/jira/browse/CB-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999681#comment-14999681
] 

ASF GitHub Bot commented on CB-9883:
------------------------------------

Github user shazron commented on the pull request:

    https://github.com/apache/cordova-ios/pull/179#issuecomment-155613091
  
    Good point, didn't think of that scenario. Ideally each WebView engine, when activated,
should inject its own bridge. This would solve this scenario. 
    
    We could do this for the WKWebViewEngine plugin -- when it is activated, read the .js
file and inject it. The UIWebViewEngine (private) plugin could do it as well in the same manner
but we would have to remove the .js from cordova-js-src folder (which is aggregated by cordova-js
to create cordova.js) and leave this as a concern for the platform itself.


> Remove unused iOS bridges
> -------------------------
>
>                 Key: CB-9883
>                 URL: https://issues.apache.org/jira/browse/CB-9883
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Jesse MacFadyen
>              Labels: cordova-ios-4.0.x
>
> We have 7 bridges in iOS:
> https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L36-L43
> IFRAME_NAV is the default, and is actively used.
> WK_WEBVIEW_BINDING will be used by the wkwebview-engine plugin,
> although I really want the plugin itself to inject this, haven't
> explored that yet.
> Remove these bridges:
> https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L38-L42
> XHR_NO_PAYLOAD
> XHR_WITH_PAYLOAD
> XHR_OPTIONAL_PAYLOAD
> IFRAME_HASH_NO_PAYLOAD
> IFRAME_HASH_WITH_PAYLOAD
> ... and their associated native code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message