cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9883) Remove unused iOS bridges
Date Tue, 10 Nov 2015 00:07:11 GMT

    [ https://issues.apache.org/jira/browse/CB-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997708#comment-14997708
] 

ASF GitHub Bot commented on CB-9883:
------------------------------------

GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-ios/pull/180

    CB-9883

    Remove last remaining alternative bridge (wk-webview)
    The wk-webview plugin is now clobbering cordova.exec to provide it's own implementation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-ios CB-9883

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #180
    
----
commit 21a71fe89ffe575d1b70ce51aa9957777ac23f17
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2015-11-07T01:53:29Z

    Removed wk-webview exec and some linting

commit 3618162251e21f1ec6d7d83be403a984152a4c55
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2015-11-10T00:04:43Z

    Update cordova.js

----


> Remove unused iOS bridges
> -------------------------
>
>                 Key: CB-9883
>                 URL: https://issues.apache.org/jira/browse/CB-9883
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Jesse MacFadyen
>              Labels: cordova-ios-4.0.x
>
> We have 7 bridges in iOS:
> https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L36-L43
> IFRAME_NAV is the default, and is actively used.
> WK_WEBVIEW_BINDING will be used by the wkwebview-engine plugin,
> although I really want the plugin itself to inject this, haven't
> explored that yet.
> Remove these bridges:
> https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L38-L42
> XHR_NO_PAYLOAD
> XHR_WITH_PAYLOAD
> XHR_OPTIONAL_PAYLOAD
> IFRAME_HASH_NO_PAYLOAD
> IFRAME_HASH_WITH_PAYLOAD
> ... and their associated native code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message