cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9883) Remove unused iOS bridges
Date Tue, 03 Nov 2015 23:35:27 GMT

    [ https://issues.apache.org/jira/browse/CB-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988476#comment-14988476
] 

ASF GitHub Bot commented on CB-9883:
------------------------------------

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-ios/pull/178

    CB-9883 - Remove unused iOS bridges

    Please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-ios CB-9883

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit 8f6c8367b476493b48e263d4bed5b5c31916d81d
Author: Shazron Abdullah <shazron@apache.org>
Date:   2015-11-03T22:20:11Z

    CB-9883 - Remove bridge changing guide doc

commit 89ea4926040b8febbde90beb04d058a19ef2e3f4
Author: Shazron Abdullah <shazron@apache.org>
Date:   2015-11-03T22:34:57Z

    CB-9883 - removed bridges from platform exec.js

commit 81f5036ef7552a3619a3b0448e534854a2be66bd
Author: Shazron Abdullah <shazron@apache.org>
Date:   2015-11-03T22:40:06Z

    CB-9883 - removed bridges from platform native code

----


> Remove unused iOS bridges
> -------------------------
>
>                 Key: CB-9883
>                 URL: https://issues.apache.org/jira/browse/CB-9883
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>              Labels: cordova-ios-4.0.x
>
> We have 7 bridges in iOS:
> https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L36-L43
> IFRAME_NAV is the default, and is actively used.
> WK_WEBVIEW_BINDING will be used by the wkwebview-engine plugin,
> although I really want the plugin itself to inject this, haven't
> explored that yet.
> Remove these bridges:
> https://github.com/apache/cordova-ios/blob/c0fe92d6c0b91efa2da0d5cec78e0baa95ce55c9/cordova-js-src/exec.js#L38-L42
> XHR_NO_PAYLOAD
> XHR_WITH_PAYLOAD
> XHR_OPTIONAL_PAYLOAD
> IFRAME_HASH_NO_PAYLOAD
> IFRAME_HASH_WITH_PAYLOAD
> ... and their associated native code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message