cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9563) Mulptipart form data is used even a header named Content-Type is present
Date Wed, 25 Nov 2015 09:52:10 GMT

    [ https://issues.apache.org/jira/browse/CB-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026522#comment-15026522
] 

ASF GitHub Bot commented on CB-9563:
------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/117#discussion_r45847057
  
    --- Diff: src/windows/FileTransferProxy.js ---
    @@ -81,6 +81,8 @@ exec(win, fail, 'FileTransfer', 'upload',
             var uploadId = options[9];
             var httpMethod = options[10];
     
    +        var isMultipart = typeof headers["Content-Type"] === 'undefined';
    --- End diff --
    
    nit: it might be better to move this definition closer to usage


> Mulptipart form data is used even a header named Content-Type is present
> ------------------------------------------------------------------------
>
>                 Key: CB-9563
>                 URL: https://issues.apache.org/jira/browse/CB-9563
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>            Reporter: Alex Mantsurov
>            Assignee: Sergey Shakhnazarov
>              Labels: triaged
>
>  I'm uploading media files to Amazon S3.
>       
>        ft.upload(
>                 path,
>                 url,
>                 function(result) {
>                     console.log(result);
>                 },
>                 function(error) {
>                     console.log(error);
>                 },
>                 {
>                     httpMethod  : 'PUT',
>                     fileName    :  name,
>                     mimeType    :  type,
>                     chunkedMode :  false,
>                     headers: {
>                         'Content-Type'   :  type,
>                         'x-amz-acl'      : 'public-read'
>                     }
>                 }
>             );
> After uploading the binary is wrapped:
> --+++++org.apache.cordova.formBoundary Content-Disposition: form-data; name="file"; filename="photo_032.jpg"
Content-Type: image/jpeg Content-Length: 43084
> {binary data}
> --+++++org.apache.cordova.formBoundary--
> So, multipart data IS USED, but according to the docs:
> if a header named Content-Type is present, multipart form data will NOT be used
> Expected result:
> if a header named Content-Type is present, multipart form data will NOT be used



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message